Update error handling and log-ability #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonccccc
reviewed
Jul 14, 2025
wilsonccccc
reviewed
Jul 14, 2025
app/main.py
Outdated
| async def invalid_provider_exception_handler(request: Request, exc: InvalidProviderException): | ||
| return HTTPException( | ||
| status_code=400, | ||
| detail=f"{str(exc)}. Please call the /models endpoint to check the valid providers/models id." |
Contributor
There was a problem hiding this comment.
Please include the full list of valid models with the link:
"""
Please verify your provider and model details by calling the /models endpoint or visiting https://tensorblock.co/api-docs/model-ids, and ensure you’re using a valid provider name, model name, and model ID.
"""
Contributor
Author
There was a problem hiding this comment.
Error msg updated. However, we could include the full list of valid models. By the time we throw this error, we simply can't match the provider/model_ids with any existing one. I think the better way is just to provide the link here for them to look up
wilsonccccc
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.